Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tanka.md so that promtail.yml is the correct format #1671

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

shokada
Copy link
Contributor

@shokada shokada commented Feb 11, 2020

Following https://github.com/grafana/loki/blob/master/docs/installation/tanka.md, I encountered the following error.

% kubectl logs promtail-pf4z7
Unable to parse config: /etc/promtail/promtail.yml: yaml: unmarshal errors:
  line 2: field container_root_path not found in type client.raw
  line 3: field hostname not found in type client.raw
  line 4: field password not found in type client.raw
  line 5: field scheme not found in type client.raw
  line 7: field username not found in type client.raw

The content of promtail.yml is the following.

% tk show environments/loki --dangerous-allow-redirect | grep -A8 'promtail.yml: |'
  promtail.yml: |
    clients:
    - container_root_path: /var/lib/docker
      hostname: gateway.loki.svc
      password: password
      scheme: http
      url: http://loki:password@gateway.loki.svc/loki/api/v1/push
      username: loki
    scrape_configs:

So, I use :: so that each field doesn't appear in the JSON output.

@claassistantio
Copy link

claassistantio commented Feb 11, 2020

CLA assistant check
All committers have signed the CLA.

@shokada shokada changed the title Update tanka.md so that promtail.yml is in the correct format Update tanka.md so that promtail.yml is the correct format Feb 11, 2020
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rfratto rfratto merged commit 4b44e50 into grafana:master Feb 11, 2020
billimek added a commit to billimek/loki that referenced this pull request Feb 13, 2020
* 'extraPorts' of github.com:billimek/loki: (25 commits)
  Ensure status codes are set correctly in the frontend. (grafana#1684)
  --dry-run Promtail. (grafana#1652)
  Fix logcli --quiet parameter parsing issue (grafana#1682)
  This improves the log ouput for statistics in the logcli. (grafana#1644)
  Loki stack helm chart can deploy datasources without Grafana (grafana#1688)
  Automatically prune metrics from the /metrics output of the promtail metrics pipeline stage after an idle period.
  Allow a metric defined as a counter to match all lines, useful for creating line count metrics which include all your labels. Found a bug in the the test runner where it didn't fail if the actual error was nil but the test expected an error Added some tests to the counters to test valid configs
  maintainer links & usernames (grafana#1675)
  Binary operators in LogQL (grafana#1662)
  Pipe data to Promtail (grafana#1649)
  Add Owen to the maintainer team. (grafana#1673)
  Update tanka.md so that promtail.yml is in the correct format (grafana#1671)
  Correcte syntax of rate example (grafana#1641)
  Frontend & Querier query statistics instrumentation. (grafana#1661)
  loki-canary: fix indent of DaemonSet manifest written in .md file (grafana#1648)
  Query frontend service should be headless. (grafana#1665)
  Support custom prefix name in metrics stage (grafana#1664)
  pkg/promtail/positions: handle empty positions file (grafana#1660)
  Convert second(Integer class) to nanosecond precision (grafana#1656)
  Unite docs for fluentd plugin (grafana#1634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants