Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes path prefix in the querier. #2178

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Conversation

cyriltovena
Copy link
Contributor

This solves the problem of path prefix in the querier only see #2176

For the frontend we need to fix cortex first, then we can also fix it in Loki.

At least with this PR people using helm and the single binary won't have this issue.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2178 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2178   +/-   ##
=======================================
  Coverage   61.58%   61.58%           
=======================================
  Files         154      154           
  Lines       12310    12310           
=======================================
  Hits         7581     7581           
+ Misses       4121     4120    -1     
- Partials      608      609    +1     
Impacted Files Coverage Δ
pkg/loghttp/versions.go 100.00% <100.00%> (ø)
pkg/logql/evaluator.go 90.02% <0.00%> (-0.54%) ⬇️
pkg/querier/queryrange/downstreamer.go 97.93% <0.00%> (+2.06%) ⬆️

@owen-d owen-d merged commit cb76da6 into grafana:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants