Improve fluentd plugin development experience #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2179 +/- ##
==========================================
- Coverage 61.60% 61.55% -0.06%
==========================================
Files 154 154
Lines 12307 12307
==========================================
- Hits 7582 7575 -7
- Misses 4118 4121 +3
- Partials 607 611 +4
|
cyriltovena
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When I implemented #2171, there appear files we should not keep in this git repository.
In addition, I found that Gemfile defines the gems used for Fluentd plugin. However, this isn't common practice to develop gems with Bundler. (See Bundler doc for the details.) So, I move gem definitions from the Gemfile to the gemspec file.
Special notes for your reviewer:
This PR does not include any code changes. I felt I can improve development experiences of this gem for other developers after I implemented #2171