Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user agent on outgoing http requests #2242

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

carlpett
Copy link
Contributor

@carlpett carlpett commented Jun 19, 2020

What this PR does / why we need it:
This PR adds a User-Agent header on outgoing HTTP requests, so it is eg promtail/v1.5.0 or loki-logcli/v1.5.0 rather than Go-http-client/1.1.

Special notes for your reviewer:
First change in this repo, so might be missing other places where it is needed.

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2020

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Calle Pettersson <calle@cape.nu>
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020

Codecov Report

Merging #2242 into master will increase coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2242      +/-   ##
==========================================
+ Coverage   62.06%   62.18%   +0.11%     
==========================================
  Files         156      156              
  Lines       12567    12569       +2     
==========================================
+ Hits         7800     7816      +16     
+ Misses       4154     4138      -16     
- Partials      613      615       +2     
Impacted Files Coverage Δ
pkg/logcli/client/client.go 5.93% <0.00%> (-0.06%) ⬇️
pkg/promtail/client/client.go 85.15% <100.00%> (+0.11%) ⬆️
pkg/promtail/positions/positions.go 60.71% <0.00%> (+13.39%) ⬆️

@cyriltovena cyriltovena merged commit baa2643 into grafana:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants