Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lock fix for flaky test #2268

Merged
merged 1 commit into from
Jun 26, 2020
Merged

lock fix for flaky test #2268

merged 1 commit into from
Jun 26, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jun 26, 2020

cyriltovena
cyriltovena approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2268 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2268      +/-   ##
==========================================
- Coverage   62.37%   62.32%   -0.05%     
==========================================
  Files         158      158              
  Lines       12718    12718              
==========================================
- Hits         7933     7927       -6     
- Misses       4171     4183      +12     
+ Partials      614      608       -6
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 47.32% <0.00%> (-13.40%) ⬇️
pkg/logql/evaluator.go 92.54% <0.00%> (+0.40%) ⬆️
pkg/promtail/targets/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️
pkg/promtail/targets/tailer.go 78.40% <0.00%> (+4.54%) ⬆️

@owen-d owen-d merged commit 48b8504 into grafana:master Jun 26, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
@bboreham
Allow more connection reuse for DynamoDB and S3 calls (grafana#2268)
1c13de1 
We will connect many times in parallel to the same DynamoDB server,
and with default settings Go will close and re-open connections; see
golang/go#13801

Raise MaxIdleConnsPerHost to avoid this.

Signed-off-by: Bryan Boreham <bryan@weave.works>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-d @codecov-commenter @cyriltovena