Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production/helm: Add projected and downwardAPI volume types to PodSecurityPolicy (#2355) #2366

Conversation

StevenReitsma
Copy link
Contributor

What this PR does / why we need it:
This PR adds the projected and downwardAPI volume types to the allowed list of volume types in the PodSecurityPolicy of the loki, promtail and fluent-bit Helm charts. See Issue #2355 for context.

Which issue(s) this PR fixes:
Fixes #2355

Special notes for your reviewer:
N/A

Checklist

  • Documentation added N/A
  • Tests updated N/A

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2366 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2366      +/-   ##
==========================================
+ Coverage   61.46%   61.62%   +0.16%     
==========================================
  Files         160      160              
  Lines       13534    13534              
==========================================
+ Hits         8318     8340      +22     
+ Misses       4589     4568      -21     
+ Partials      627      626       -1     
Impacted Files Coverage Δ
pkg/promtail/targets/file/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️
pkg/promtail/targets/file/tailer.go 78.40% <0.00%> (+4.54%) ⬆️
pkg/promtail/positions/positions.go 60.71% <0.00%> (+13.39%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe we could have made it optional by using extras.psp.Volumes, I'm fine with this for now unless someone complain in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki and promtail unable to start when using Istio and PodSecurityPolicies
4 participants