Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production/helm: Add emptyDir volume type to promtail PSP #2379

Conversation

StevenReitsma
Copy link
Contributor

What this PR does / why we need it:
Forgot that istio also needs emptyDir volume for #2355...

Which issue(s) this PR fixes:
Fixes #2355

Special notes for your reviewer:
Related PR: #2366

Checklist

  • Documentation added N/A
  • Tests updated N/A

@StevenReitsma StevenReitsma changed the title Add emptyDir volume type to promtail PSP production/helm: Add emptyDir volume type to promtail PSP Jul 20, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #2379 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2379      +/-   ##
==========================================
- Coverage   61.73%   61.66%   -0.08%     
==========================================
  Files         160      160              
  Lines       13569    13569              
==========================================
- Hits         8377     8367      -10     
- Misses       4565     4579      +14     
+ Partials      627      623       -4     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 47.32% <0.00%> (-13.40%) ⬇️
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️
pkg/promtail/targets/file/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️
pkg/promtail/targets/file/tailer.go 78.40% <0.00%> (+4.54%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 6798469 into grafana:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki and promtail unable to start when using Istio and PodSecurityPolicies
3 participants