Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Note that entry_parser is deprecated. #2397

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

coderanger
Copy link
Contributor

What this PR does / why we need it:

Minor doc addition so new users like me don't get side tracked by "should I be using entry_parser or a pipeline stage?"

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2397 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
- Coverage   61.72%   61.59%   -0.14%     
==========================================
  Files         160      160              
  Lines       13577    13577              
==========================================
- Hits         8381     8363      -18     
- Misses       4569     4592      +23     
+ Partials      627      622       -5     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 47.32% <0.00%> (-13.40%) ⬇️
pkg/canary/comparator/comparator.go 77.82% <0.00%> (-2.42%) ⬇️
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️
pkg/promtail/targets/file/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️
pkg/promtail/targets/file/tailer.go 76.13% <0.00%> (+2.27%) ⬆️

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@slim-bean slim-bean merged commit 47aa1db into grafana:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants