Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - update links, readme #2398

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Docs - update links, readme #2398

merged 2 commits into from
Jul 23, 2020

Conversation

robbymilo
Copy link
Contributor

What this PR does / why we need it:

  • Updates docs links
  • Updates README on how docs are updated.

Checklist

  • Documentation added
  • Tests updated

slim-bean
slim-bean previously approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean
Copy link
Collaborator

Actually on second thought, should we just make all those absolute links relative so we don't have to specify the domain?

@slim-bean slim-bean dismissed their stale review July 23, 2020 12:09

had a second thought

owen-d
owen-d approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm!

@owen-d owen-d merged commit e2f1581 into master Jul 23, 2020
@owen-d owen-d deleted the robbymilo/docs branch July 23, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

@slim-bean slim-bean slim-bean left review comments

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robbymilo @slim-bean @owen-d