Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set service values via --set for logstash. #2415

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

cyriltovena
Copy link
Contributor

As per discussed in #2406.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

As per discussed in grafana#2406.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2415 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
- Coverage   61.58%   61.57%   -0.02%     
==========================================
  Files         160      160              
  Lines       13590    13590              
==========================================
- Hits         8370     8368       -2     
- Misses       4597     4598       +1     
- Partials      623      624       +1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️
pkg/promtail/targets/file/tailer.go 78.40% <0.00%> (ø)

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you :)

@owen-d owen-d merged commit d93b410 into grafana:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants