Helm: Fix regression in chart name #2406
Conversation
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Codecov Report
@@ Coverage Diff @@
## master #2406 +/- ##
==========================================
- Coverage 61.67% 61.65% -0.02%
==========================================
Files 160 160
Lines 13577 13577
==========================================
- Hits 8373 8371 -2
- Misses 4581 4583 +2
Partials 623 623
|
| @@ -41,7 +38,6 @@ filebeat: | |||
|
|
|||
| logstash: | |||
| enabled: false | |||
| fullnameOverride: logstash-loki | |||
There was a problem hiding this comment.
The problem is this is required for the default chart to work with logstash.
Unfortunately there is no way to know the service name within the value file. This is used by both the filebeat.yml and the main output of logstash.
Do you have an alternative ?
There was a problem hiding this comment.
I don't think it makes sense to break existing deployments for a disabled by default feature. A better alternative is to enhance the upstream chart to support templating of the necessary values so you can specify templated values in the values.yaml. For example, here is the config from my values.yaml to configure Grafana to use Loki (which by the way is broken currently due to this issue):
grafana:
additionalDataSources:
- name: Loki
type: loki
access: proxy
url: http://{{ .Release.Name }}-loki:3100
jsonData:
maxLines: 500See the templating PR I did for Grafana's ingress annotations to see how it's done. I don't use logstash or know which fields have to be templated to be able to help with this.
Or if that's not feasible then simply documenting how users can adjust the chart for use with Logstash should suffice.
There was a problem hiding this comment.
Gonna need some time to figure this out. May be we can add those override in the docs via —set for now as examples for logstash.
There was a problem hiding this comment.
I found an other bug with those templates, for example promtail in the umbrella chart will use the stack template but with value from the subchart and the template is wrong.
Subchart and templates is not a fun area.
There was a problem hiding this comment.
Alright I've sent a PR to make this part of the doc instead.
As per discussed in grafana#2406. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
Thanks @cyriltovena! |
As per discussed in #2406. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
As per discussed in grafana#2406. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
What this PR does / why we need it:
Fixes a regression caused by the Logstash PR #1822. That PR populated the
fullnameOverridefor sub-charts, breaking existing deployments and external resources depending upon the release-prefixed service name.fullnameOverrideis an optional field for users to override the name, it shouldn't be set by charts. Helm best practice is that workload names contain the release name so that you can deploy the same chart multiple times to the same namespace.Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist