Promtail: adding pipeline stage for dropping labels #2571
Conversation
…o move unbound labels into the log line and dropping the label, fixes grafana#2421 Signed-off-by: Roger Steneteg <rsteneteg@ea.com>
Codecov Report
@@ Coverage Diff @@
## master #2571 +/- ##
==========================================
- Coverage 62.85% 62.81% -0.05%
==========================================
Files 169 170 +1
Lines 14913 14937 +24
==========================================
+ Hits 9374 9383 +9
- Misses 4790 4804 +14
- Partials 749 750 +1
|
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
|
This looks really good btw, almost had a chance to get to review this today but it might have to wait until next week we have a lot of folks on PTO. Thank you though and we will get this merged soon!! ❤️ |
pkg/logentry/stages/labeldrop.go
Outdated
|
|
||
| const ( | ||
| // ErrEmptyLabelDropStageConfig error returned if config is empty | ||
| ErrEmptyLabelDropStageConfig = "drop_label stage config cannot be empty" |
There was a problem hiding this comment.
drop_label and labeldrop ? There is some inconsistency here. Should we rename this to drop_labels everywhere ? WDYT ? naming is hard but also important.
There was a problem hiding this comment.
thanks for finding that, I switched that out to labeldrop, I picked "labeldrop" over "drop_label" because the relabel action to drop labels is called labeldrop so thought it would be more consistent.
There was a problem hiding this comment.
Looks good to me, I'd like @slim-bean to chime in for the name of the stage.
Signed-off-by: Roger Steneteg <rsteneteg@ea.com>
|
|
* Translate internal store errors to prometheus API errors. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added integration test for chunks querier and query-frontend. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Account for one extra query. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix test after rebase. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Adding a pipeline stage in Promtail to drop labels
Signed-off-by: Roger Steneteg rsteneteg@ea.com
What this PR does / why we need it:
Adding a pipeline stage to drop labels, our use case for this is to move unbound labels into the log line and dropping the label
Which issue(s) this PR fixes:
Fixes #2421
Special notes for your reviewer:
Checklist