Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline stages should support dropping labels #2421

Closed
slim-bean opened this issue Jul 25, 2020 · 1 comment · Fixed by #2571
Closed

Pipeline stages should support dropping labels #2421

slim-bean opened this issue Jul 25, 2020 · 1 comment · Fixed by #2571
Labels
help wanted We would love help on these issues. Please come help us!

Comments

@slim-bean
Copy link
Collaborator

Several use cases have been presented for removing labels from a stream, the primary case is removing the filename label which Promtail automatically appends to every stream after it derives it from the __path__ label.

In some cases this information is superfluous and it would be nice to be able to remove it.

Rather than just special casing this label I think a label_drop pipeline stage (name alternatives welcome :) ) would generally be useful and should be added.
@slim-bean slim-bean added the help wanted We would love help on these issues. Please come help us! label Jul 25, 2020
@stale
Copy link

stale bot commented Aug 24, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Aug 24, 2020
rsteneteg added a commit to rsteneteg/loki that referenced this issue Aug 28, 2020
@rsteneteg
adding pipeline stage for dropping labels, our use case for this is t…
088e2af 
…o move unbound labels into the log line and dropping the label, fixes grafana#2421

Signed-off-by: Roger Steneteg <rsteneteg@ea.com>
@rsteneteg rsteneteg mentioned this issue Aug 28, 2020
Merged
2 tasks
@stale stale bot closed this as completed Aug 31, 2020
@slim-bean slim-bean reopened this Sep 1, 2020
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Sep 1, 2020
cyriltovena pushed a commit that referenced this issue Sep 10, 2020
@rsteneteg @oddlittlebird
Promtail: adding pipeline stage for dropping labels (#2571)
edb5fc5 
* adding pipeline stage for dropping labels, our use case for this is to move unbound labels into the log line and dropping the label, fixes #2421

Signed-off-by: Roger Steneteg <rsteneteg@ea.com>

* Update docs/sources/clients/promtail/stages/labeldrop.md

Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>

* Update docs/sources/clients/promtail/stages/_index.md

Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>

* fixed inconsistent naming, removed unused logger in the labeldrop stage

Signed-off-by: Roger Steneteg <rsteneteg@ea.com>

Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted We would love help on these issues. Please come help us!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Promtail: adding pipeline stage for dropping labels rsteneteg/loki
1 participant
@slim-bean