Ruler docs + single binary inclusion #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
requested review from
achatterjee-grafana and
oddlittlebird
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2637 +/- ##
=======================================
Coverage 61.22% 61.22%
=======================================
Files 172 172
Lines 13360 13360
=======================================
Hits 8180 8180
Misses 4431 4431
Partials 749 749
|
oddlittlebird
suggested changes
Sep 17, 2020
There was a problem hiding this comment.
I didn't get all the way through this PR before my day ended, but this should give you a good start. A few things:
- Capitalize Loki. It's the name of a product, so a proper noun.
- All headings should be sentence case.
- Do not use an ampersand to abbreviate "and."
- I strongly recommend breaking up the larger files into smaller subtopics. This makes them a lot easier to navigate and read.
oddlittlebird
suggested changes
Sep 18, 2020
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
oddlittlebird
approved these changes
Sep 21, 2020
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
slim-bean
reviewed
Sep 21, 2020
slim-bean
reviewed
Sep 21, 2020
slim-bean
reviewed
Sep 21, 2020
slim-bean
approved these changes
Sep 21, 2020
wardbekker
reviewed
Sep 22, 2020
| - Recording rules. | ||
| - Backend metric stores adapters for generated alert and recording rule data. The first will likely be Cortex, as Loki is built atop it. | ||
| - The first will likely be Cortex, as Loki is built atop it. | ||
| - Introduce LogQL v2. |
There was a problem hiding this comment.
will this naming be evergreen?
There was a problem hiding this comment.
I don't know -- this doc will probably need some updates as things progress.
Co-authored-by: Ed Welch <ed@oqqer.com> Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to docs, this PR adds
make docscommand (it still orphans processes but haven't had the time to dig into that). It's now interactive & can be SIGINT'd to return control to your terminal. However you'll accrue orphaned docker containers.