Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information about why a tailer would stop. #3015

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Should help #2979 discover the reason why it stopped.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #3015 (1e91bc4) into master (854930e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
+ Coverage   62.39%   62.42%   +0.03%     
==========================================
  Files         185      185              
  Lines       15626    15626              
==========================================
+ Hits         9750     9755       +5     
+ Misses       4949     4945       -4     
+ Partials      927      926       -1     
Impacted Files Coverage Δ
pkg/promtail/targets/file/tailer.go 69.52% <100.00%> (ø)
pkg/promtail/targets/file/filetarget.go 66.19% <0.00%> (+2.11%) ⬆️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

Copy link
Collaborator

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owen-d owen-d merged commit 3159724 into grafana:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants