Jsonnet: Changes ingester PVC from 5Gi to 10Gi #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixed the ingester deployment to use this value, however the hard coded value was 10Gi and this default was 5Gi. This is a dissalowed change in kubernetes and causes deployment failures. Changing this back to 10Gi isn't ideal however because anyone who also deployed with the 5Gi is now in the same situation. I think however more people are going to find themselves impacted by this change as it existed for a lot longer as 10Gi than 5Gi.
owen-d
approved these changes
Jan 15, 2021
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Allow to override server name This allows to override the expected server name during TLS server validation. This simplifies the TLS setup as a ServerName can be more predictable than for example IP addresses. Fixes grafana#3063 Improve TLS client test coverage Add integration tests that spin up a HTTP/GRPC server and verify that the client options behave in the expected way. Allow configuration of non-mutual TLS Explicitly enable TLS in the client with the flag `-<prefix>.tls-enabled`. This flag is implicitly enabled when any other TLS flag is set. This flag will only be respected by the GRPC client, as for the HTTP client the scheme used in the URL will take precedence. Signed-off-by: Christian Simon <simon@swine.de> Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com> Co-authored-by: Christian Simon <simon@swine.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to PR #3079 which correctly fixed the ingester deployment to use this value, the hard coded value was 10Gi and this default was 5Gi.
3079 then effectively changed the default from 10Gi to 5Gi, this is a dissalowed change in kubernetes and causes deployment failures.
Unfortunately making this change from 5Gi to 10Gi is also a breaking change for anyone who installed while it was 5Gi.
I'm making this decision strictly on the assumption that more people installed when it was 10Gi and will be impacted by it changing from 10Gi to 5Gi