Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingester PVC data declaration to use configured value #3079

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

rajatvig
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #3079 (3c079bd) into master (e9001d8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3079      +/-   ##
==========================================
+ Coverage   62.86%   62.88%   +0.02%     
==========================================
  Files         186      186              
  Lines       15949    15949              
==========================================
+ Hits        10026    10030       +4     
+ Misses       4996     4988       -8     
- Partials      927      931       +4     
Impacted Files Coverage Δ
pkg/querier/queryrange/limits.go 91.66% <0.00%> (-4.17%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
pkg/promtail/targets/file/filetarget.go 64.33% <0.00%> (-2.10%) ⬇️
pkg/promtail/positions/positions.go 58.51% <0.00%> (+11.70%) ⬆️

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants