Fixes panic when using multiple clients #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try. Introduce by grafana#3175. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
changed the title
sandeepsukhani
approved these changes
Jan 21, 2021
| } | ||
|
|
||
| return &m | ||
| } | ||
|
|
||
| func mustRegisterOrGet(reg prometheus.Registerer, c prometheus.Collector) prometheus.Collector { |
There was a problem hiding this comment.
Would it be good to not return the prometheus.Collector? It would simplify things and make it clear that the method is just for registering the collector without modifying it.
There was a problem hiding this comment.
I need it actually so all client can increment the metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panic is happening because we use multiple client with the same registry. This should be supported.
Introduced by #3175.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com