Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtail: pass a prometheus registerer to promtail components #3175

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jan 14, 2021

Closes #3174

Signed-off-by: Robert Fratto robertfratto@gmail.com

Signed-off-by: Robert Fratto <robertfratto@gmail.com>
@rfratto rfratto marked this pull request as ready for review January 15, 2021 15:37
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - I know it's not the most fun work :)

@owen-d owen-d merged commit 628c1fa into grafana:master Jan 15, 2021
cyriltovena added a commit to cyriltovena/loki that referenced this pull request Jan 21, 2021
…try.

Introduce by grafana#3175.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena added a commit that referenced this pull request Jan 21, 2021
…try. (#3207)

Introduce by #3175.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass custom Prometheus registerer to promtail
2 participants