Refactor logcli Client interface to use time objects for LiveTailQueryConn #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepsukhani
requested changes
Feb 1, 2021
There was a problem hiding this comment.
Suggested a minor fix. Can you also please rebase the PR?
I have merged #3270
chancez
force-pushed
the
refactor_logcli_client
branch
from
9c97361
to
4389603
Compare
|
Updated and rebased. |
…ration for LiveTailQueryConn method
chancez
force-pushed
the
refactor_logcli_client
branch
from
4389603
to
d2e3b31
Compare
sandeepsukhani
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactors the logcli Client interface to use
time.Timeandtime.Durationlikeall the other methods use, for consistency and to reduce possible user-errors
when converting between times and integers.
Special notes for your reviewer:
Depends on #3270, which this PR builds upon. Separate PRs to handle bug fixes
and refactoring separately.