logcli: Fix handling of logcli query using --since/--from and --tail #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uery parameters Instead of using from/through, use start/end like the Loki API does.
chancez
commented
Jan 29, 2021
| qsb := util.NewQueryStringBuilder() | ||
| qsb.SetString("query", queryStr) | ||
| qsb.SetInt("delay_for", int64(delayFor)) | ||
| qsb.SetInt("limit", int64(limit)) | ||
| qsb.SetInt("from", from) |
sandeepsukhani
approved these changes
Feb 1, 2021
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
Signed-off-by: Ben Wells <b.v.wells@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes handling of
--since/--frominlogcli querywhen used with--tail.Also changes uses of variable names in the logcli Client interface to match the
query parameter names for the Loki API for consistency.
Which issue(s) this PR fixes:
Fixes #3269