Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about regex #3437

Merged
merged 1 commit into from
Mar 8, 2021
Merged

docs: add note about regex #3437

merged 1 commit into from
Mar 8, 2021

Conversation

caleb15
Copy link
Contributor

@caleb15 caleb15 commented Mar 4, 2021

to prevent people from running into #3436

What this PR does / why we need it:

  • The |~ operator is a partial match. One would intuitively expect that =~ would behave the same way, but it is in fact a exact match. It's important to point that out.
  • Many log lines have newlines in them (at least in my case), so it's important to remind users that . does not match newlines by default.

Which issue(s) this PR fixes:
Fixes #3436

Special notes for your reviewer:

Checklist

  • Documentation added
  • [N/A] Tests updated

to prevent people from running into grafana#3436
@CLAassistant
Copy link

CLAassistant commented Mar 4, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice digging to find this :).

@owen-d owen-d merged commit 4f27c75 into grafana:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logcli field regex does not return results
3 participants