Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Remove removed --ingester.recover-from-wal option and fix out-of-date defaults #3559

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Doc: Remove removed --ingester.recover-from-wal option and fix out-of-date defaults #3559

merged 2 commits into from
Jul 8, 2021

Conversation

klausenbusk
Copy link
Contributor

What this PR does / why we need it:

Remove removed --ingester.recover-from-wal option and fix out-of-date defaults

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2021

CLA assistant check
All committers have signed the CLA.

@klausenbusk klausenbusk changed the title Docs: Remove removed --ingester.recover-from-wal option and fix out-of-date defaults Doc: Remove removed --ingester.recover-from-wal option and fix out-of-date defaults Mar 31, 2021
0b1dbe2 ("Promtail: Add a stream lagging metric (#2618)")
d3bf21e ("Promtail: (and also fluent-bit) change the max batch size to 1MB  (#2710)")
@codecov-io
Copy link

Codecov Report

Merging #3559 (23cd2d1) into master (46eff3c) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3559      +/-   ##
==========================================
+ Coverage   63.18%   63.21%   +0.03%     
==========================================
  Files         206      206              
  Lines       17774    17774              
==========================================
+ Hits        11230    11236       +6     
+ Misses       5543     5536       -7     
- Partials     1001     1002       +1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 89.83% <0.00%> (-0.36%) ⬇️
pkg/querier/queryrange/limits.go 88.57% <0.00%> (+1.90%) ⬆️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️
pkg/promtail/targets/file/filetarget.go 66.89% <0.00%> (+2.75%) ⬆️

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jun 2, 2021
@klausenbusk
Copy link
Contributor Author

Let's hope someone is gonna merge it :)

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jun 2, 2021
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jul 8, 2021
@klausenbusk
Copy link
Contributor Author

....

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jul 8, 2021
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the really long wait on this. The fix looks great

@owen-d owen-d merged commit 021a7fd into grafana:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants