Promtail: (and also fluent-bit) change the max batch size to 1MB #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fluent-bit, attempt to centralize this config a little where possible.
cyriltovena
reviewed
Oct 1, 2020
| @@ -11,6 +11,16 @@ import ( | |||
| lokiflag "github.com/grafana/loki/pkg/util/flagext" | |||
| ) | |||
|
|
|||
| // NOTE the helm chart for promtail and fluent-bit also have defaults for these values, please update to match if you make changes here. | |||
There was a problem hiding this comment.
pretty sure we could find a way at some point to have global default.
There was a problem hiding this comment.
helm makes this difficult, we specify the values in the config so they can be overridden but i think leaving them empty would be an error, I don't have the time to dig deeper into this right now so I added this comment as "better than nothing"
Codecov Report
@@ Coverage Diff @@
## master #2710 +/- ##
==========================================
- Coverage 61.37% 61.32% -0.06%
==========================================
Files 173 173
Lines 13444 13444
==========================================
- Hits 8251 8244 -7
- Misses 4440 4444 +4
- Partials 753 756 +3
|
slim-bean
added a commit
that referenced
this pull request
Oct 1, 2020
* change the max batch size to 1MB for all the defaults including helm and fluent-bit, attempt to centralize this config a little where possible. * fix test (cherry picked from commit d3bf21e)
owen-d
pushed a commit
that referenced
this pull request
Jul 8, 2021
…-date defaults (#3559) * Doc: Remove removed --ingester.recover-from-wal option Removed in: 8a9b94a ("removes recover flag (#3326)") * Doc: Fix out-of-date defaults 0b1dbe2 ("Promtail: Add a stream lagging metric (#2618)") d3bf21e ("Promtail: (and also fluent-bit) change the max batch size to 1MB (#2710)")
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
…fana#2710) * change the max batch size to 1MB for all the defaults including helm and fluent-bit, attempt to centralize this config a little where possible. * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the change to increase batch size made in #2618 but to also apply it in the handful of other places we have the defaults specified. I tried to centralize this a little but more work needs to be done stop defining defaults in helm and fluent-bit...