fix: Restore /config endpoint and correct handlerFunc for buildinfo #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell from reading the "next" documentation, the /loki/api/v1/status/buildinfo endpoint should return the build information. The /version endpoint is also listed further down in the documentation but from the code prior to this change, it looks like it should perform the same function as buildinfo endpoint so I have removed it. I've updated the documentation to reflect my changes. Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
|
|
|
@jeschkies Adding you on this PR to get your insight for the previous change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As far as I can tell from reading the "next" documentation, the
/loki/api/v1/status/buildinfo endpoint should return the build
information. The /version endpoint is also listed further down in the
documentation but from the code prior to this change, it looks like it
should perform the same function as buildinfo endpoint so I have
removed it.
I've updated the documentation to reflect my changes.
Special notes for your reviewer:
I'm just pulling the documentation image in order to check that the changed heading works as expected.LGTMChecklist