Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Reformat Go files #4304

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Chore: Reformat Go files #4304

merged 2 commits into from
Sep 10, 2021

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Sep 10, 2021

What this PR does / why we need it:
Format Go files with Go 1.17, which has a new build tag directive format. No biggie, but whenever I change these files goimports changes them to add the new build tag directive. If we reformat now, this problem goes away :)

Which issue(s) this PR fixes:

Special notes for your reviewer:
The changes were made through make format.

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 requested a review from a team as a code owner September 10, 2021 06:43
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @aknuds1! Left a couple comments for my squad

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@dannykopping dannykopping merged commit bfb4b00 into main Sep 10, 2021
@dannykopping dannykopping deleted the chore/format-go branch September 10, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants