Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki: Change default limits to common values #4415

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Loki: Change default limits to common values #4415

merged 5 commits into from
Oct 13, 2021

Commits on Oct 13, 2021

  1. Change some default limits to reasonable values. 

    - These new limits protect users from overwhelming their cluster with
  ingestion load
- The new limits are:
  * ingestion_rate_strategy: global <- currently defaults to local
  * max_global_streams_per_user: 5000 <- current default is no limit
  * max_query_length: 721h <- current default is no limit
  * max_query_parallelism: 32 <- current default is 14
  * max_streams_per_user: 0 <- current default is 10000
  * reject_old_samples: true <-- current default is false
  * reject_old_samples_max_age: 168h <-- current default is 336h
    @DylanGuedes
    DylanGuedes committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    a8c604f View commit details
    Browse the repository at this point in the history

  2. Remove parameters from examples 

    - They are not necessary anymore because of the new default values
    @DylanGuedes
    DylanGuedes committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    d584f4e View commit details
    Browse the repository at this point in the history

  3. Add new entries to CHANGELOG and upgrading guide

    @DylanGuedes
    DylanGuedes committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    087336b View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
    @DylanGuedes @trevorwhitney
    DylanGuedes and trevorwhitney committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    e86a7f7 View commit details
    Browse the repository at this point in the history

  5. Change changelog mark entry from '-' to '*'

    @DylanGuedes
    DylanGuedes committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    36e033c View commit details
    Browse the repository at this point in the history