Promtail: fix filetarget to not be stuck if no files was detected on startup #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Steneteg <rsteneteg@ea.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roger Steneteg rsteneteg@ea.com
What this PR does / why we need it:
Fixes a bug causing Promtail FileTargets to be stuck if no files was matched during startup
The root issue is that for statefulsets where the pod name is the same, all labels match, so the filetargetmanager already have a target with the same labels, so it will not do anything, and the filetarget has stopped because the logfile no longer exists because the path to the logfile has changed since it contains the UID of the pod which is not the same. So to fix this the manager now updates the filetarget with the new path, allowing the filetarget to pick up the new log file.
The issue with the previous fix where the manager removed the target if it was not Ready() (meaning the target has no files to tail) had the side effect that it stopped the filetarget, and removed the target from the manager preventing that filetarget from being recreated.
Which issue(s) this PR fixes:
Fixes #4460
Special notes for your reviewer:
Checklist