Expose Kafka message key in labels #4745
Merged
+152
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
taisho6339
force-pushed
the
feature/issue/4728
branch
2 times, most recently
from
5efab84
to
da986b7
Compare
cyriltovena
reviewed
Nov 16, 2021
| labelKeyKafkaMessageKey = "__meta_kafka_message_key" | ||
| ) | ||
|
|
||
| func (t *Target) messageKeyLabel() (useLabel bool, labelName model.LabelName) { |
There was a problem hiding this comment.
I think we should pass the actual value to the format and not a default since relabeling can match regexes to apply change or not.
In fact all discovered labels should be there since you can compute multiple label values using source_labels but that sounds even trickier.
Let's start with passing the value and we'll see how we can handle the rest later. (Possibly relabel everything twice, once for the target labels, once for the message)
There was a problem hiding this comment.
Oh, you're right.
Let's start with passing the value
Anyway, let me do that
taisho6339
force-pushed
the
feature/issue/4728
branch
from
d864821
to
6a50f6c
Compare
|
I've fixed to pass actual value in message key and left a TODO comment for #4745 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Expose Kafka message key in label set and add description into the documents.
Which issue(s) this PR fixes:
Fixes #4728
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.