Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(promtail): Improving promtail asset generation makefile targets #839

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

slim-bean
Copy link
Collaborator

  • Primarily this stop deletion of the generated file on a make clean which keeps the working directory diff free
  • The generated file now checks all the input files to see if there are changes to determine if the target needs to be run
  • Updated check-generated-files to include the promtail generated ui file

* Primarily this stop deletion of the generated file on a `make clean` which keeps the working directory diff free
* The generated file now checks all the input files to see if there are changes to determine if the target needs to be run
* Updated check-generated-files to include the promtail generated ui file
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 1fc2786 into master Aug 1, 2019
@slim-bean slim-bean deleted the improve-asset-cleaning branch August 1, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants