Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(build): Update docs around releasing and fix bug in version updating script #910

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

slim-bean
Copy link
Collaborator

No description provided.

…the release_prepare.sh script and tweaking the output based on the current process.
@slim-bean slim-bean requested a review from rfratto August 19, 2019 00:23
@sh0rez
Copy link
Member

sh0rez commented Aug 19, 2019

What about renaming release-prepare to release-finish for now, because it happens after the release?

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I'd also like to see documentation for how to include the release binaries (specifically the ARM ones), since I'm not sure how you do it.

@slim-bean
Copy link
Collaborator Author

What about renaming release-prepare to release-finish for now, because it happens after the release?

I think I'd like to leave it for now as I am debating ways to handle our helm chicken and egg problem (which is the only reason we don't run this first)

I am debating one solution: have the release_prepare script create the branch so it can specify a special name which we could use in a branches filter on the helm-test to prevent running the test on this specific branch name

@slim-bean
Copy link
Collaborator Author

slim-bean commented Aug 19, 2019

LGTM although I'd also like to see documentation for how to include the release binaries (specifically the ARM ones), since I'm not sure how you do it.

This is done automatically by circle CI during the tag build, via make publish

@slim-bean slim-bean merged commit 52efdfd into master Aug 20, 2019
@slim-bean slim-bean deleted the release-notes branch August 20, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants