Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

WIP: add concurrency limits on find requests #1370

Closed
wants to merge 2 commits into from

Conversation

woodsaj
Copy link
Member

@woodsaj woodsaj commented Jun 26, 2019

  • Adds a max-concurrent-finds config option and code to limit
    the number of Finds() that can be running at any one time.
  • Find() and findMaybeCached() functions have been refactored
    to avoid concurrency limits being applied to queries that
    are served from the findCache.

- Adds a max-concurrent-finds config option and code to limit
  the number of Finds() that can be running at any one time.
- Find() and findMaybeCached() functions have been refactored
  to avoid concurrency limits being applied to queries that
  are served from the findCache.
@woodsaj
Copy link
Member Author

woodsaj commented Jun 26, 2019

To make the concurrency limits useful, we really need to have find requests that are blocked for too long fail. This should be achieved by passing a context through to the request as mentioned in issue #1362 (edit @fitzoh : make that #514)

@Dieterbe Dieterbe added this to the sprint-7 milestone Jan 7, 2020
@replay replay removed this from the sprint-7 milestone Jan 27, 2020
@Dieterbe Dieterbe added this to the sprint-8 milestone Jan 27, 2020
@replay replay modified the milestones: sprint-8, sprint-9 Feb 24, 2020
@fkaleo fkaleo modified the milestones: sprint-9, sprint-10 Apr 6, 2020
@Dieterbe Dieterbe removed this from the sprint-10 milestone Apr 27, 2020
@stale
Copy link

stale bot commented Jul 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 26, 2020
@stale stale bot closed this Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants