Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

move schema into metrictank #1434

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Conversation

robert-milan
Copy link
Contributor

@robert-milan robert-milan commented Aug 15, 2019

This moves the vendored code from raintank/schema into Metrictank. Other projects will need to be updated after this is merged.

After this is merged the documentation at godoc.org will be udpated and reflect what is currently in the documentation found at docs/inputs.md

@robert-milan robert-milan changed the title move schema into metrictank WIP: move schema into metrictank Aug 15, 2019
@woodsaj
Copy link
Member

woodsaj commented Aug 15, 2019

Looks like go vet or gofmt changes have been applied to everything in vendor/, that should be reverted.

Otherwise looks good to me.

@robert-milan
Copy link
Contributor Author

Looks like go vet or gofmt changes have been applied to everything in vendor/, that should be reverted.

Otherwise looks good to me.

Yes they were, I am just undoing that and updating go generate right now

Copy link
Member

@woodsaj woodsaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-milan robert-milan changed the title WIP: move schema into metrictank move schema into metrictank Aug 15, 2019
@robert-milan robert-milan merged commit da447e6 into master Aug 15, 2019
@robert-milan robert-milan deleted the move-schema-into-metrictank branch August 15, 2019 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants