Fixes @ modifier when splitting queries by time. #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will replace `start` and `end` at (`@`) modifier with the actual constant values based on the original queries. Meaning subqueries will not wrongly use their own query start and end time. see cortexproject/cortex#4463 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
bboreham
approved these changes
Sep 8, 2021
cyriltovena
added a commit
that referenced
this pull request
Sep 20, 2021
This was introduced by #206, this is because the frontend will by default convert any error into 500. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
3 tasks
pracucci
pushed a commit
that referenced
this pull request
Sep 20, 2021
This was introduced by #206, this is because the frontend will by default convert any error into 500. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace
startandendat (@) modifier with the actual constant values based on the original queries.Meaning subqueries will not wrongly use their own query start and end time.
see cortexproject/cortex#4463
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]