Add ingester push errors to errors catalogue #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenador
force-pushed
the
zenador/err-cat-ingester
branch
from
75002b0
to
b4fb85e
Compare
pracucci
reviewed
Jun 12, 2022
osg-grafana
reviewed
Jun 13, 2022
There was a problem hiding this comment.
I approve the suggestions that @pracucci recommended, with one tiny nit.
zenador
force-pushed
the
zenador/err-cat-ingester
branch
from
b4fb85e
to
c1dc183
Compare
pracucci
reviewed
Jun 16, 2022
Co-authored-by: Marco Pracucci <marco@pracucci.com>
pracucci
approved these changes
Jun 17, 2022
zenador
force-pushed
the
zenador/err-cat-ingester
branch
from
bd13f55
to
b8f6b57
Compare
Co-authored-by: Marco Pracucci <marco@pracucci.com>
3 tasks
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
* Add ingester push errors to errors catalogue * Apply suggestions from code review Co-authored-by: Marco Pracucci <marco@pracucci.com> * Manually apply suggestions from code review * Apply suggestions from code review Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Following what we've done in #1888, this PR adds common ingester push errors to the errors catalogue.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]