Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

err-mimir-sample-timestamp-too-old event logs don't match cortex_discarded_samples_total label #5970

Open
pr00se opened this issue Sep 7, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@pr00se
Copy link
Contributor

pr00se commented Sep 7, 2023

sample-out-of-bounds error logs were changed to say sample-timestamp-too-old, but the same events are exposed as part of the cortex_discarded_samples_total metric with the old sample-out-of-bounds label. This leads to confusion when trying to tie metrics and logs together, unless you intrinsically know to do this translation.

We should change the metric label to match the logs, as that is the preferred phrasing for this type of discard.

@pr00se pr00se added the good first issue Good for newcomers label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant