-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental read write deployment mode support to Mimir #2754
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Helm <> Jsonnet Diff
If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag Please see the contribution docs here for more info. Expand to see the outputOutput of https://github.com/grafana/mimir/actions/runs/2875609478 Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
diff -r -u -N scratch/./helm/07-config/query-scheduler-MimirConfig.yml scratch/./jsonnet/08-config/query-scheduler-MimirConfig.yml
--- scratch/./helm/07-config/query-scheduler-MimirConfig.yml 2022-08-17 13:22:10.774444866 +0000
+++ scratch/./jsonnet/08-config/query-scheduler-MimirConfig.yml 2022-08-17 13:22:18.314871285 +0000
@@ -498,7 +498,7 @@
min_ready_duration: 15s (default)
observe_period: 0s (default)
replication_factor: 3 (default)
- tokens_file_path: /data/tokens
+ tokens_file_path: ' (default)'
zone_awareness_enabled: false (default)
tsdb_config_update_period: 15s (default)
ingester_client:
@@ -881,7 +881,7 @@
secondary: ' (default)'
store: memberlist (default)
replication_factor: 3 (default)
- tokens_file_path: /data/tokens
+ tokens_file_path: ' (default)'
unregister_on_shutdown: true (default)
wait_stability_max_duration: 5m0s (default)
zone_awareness_enabled: false (default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean and easy to follow, lgtm!
What this PR does
In this PR I'm introducing the targets to run the read-write deployment mode, as described in #2749. The Alertmanager is the only component currently excluded and will be addressed in a separate PR. Integration tests, support for dashboards and alerts, and documetation will be covered by follow up PRs.
I've also introduced a local development environment to easily run it.
In details, as separate commits:
Which issue(s) this PR fixes or relates to
Part of #2749
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]