Add alertmanager support to backend target #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
This was referenced Aug 25, 2022
colega
approved these changes
Aug 26, 2022
| @@ -66,7 +66,7 @@ func checkDirectoriesReadWriteAccess( | |||
| if cfg.isAnyModuleEnabled(All, Ruler, Backend) { | |||
| errs.Add(errors.Wrap(checkDirReadWriteAccess(cfg.Ruler.RulePath, dirExistFn, isDirReadWritableFn), "ruler")) | |||
| } | |||
| if cfg.isAnyModuleEnabled(AlertManager) { | |||
| if cfg.isAnyModuleEnabled(AlertManager, Backend) { | |||
There was a problem hiding this comment.
Not strictly related to this PR, but I think that at this point we need a cfg.isEnabledAnyModuleIncluding(AlertManager) that should solve the dependency tree. Otherwise all these changes are very error-prone.
There was a problem hiding this comment.
Yes, I agree. I tried to it few weeks ago and was slightly harder than I though, because we have the dependency tree after we run most of the code currently calling isAnyModuleEnabled(). So, it needs some refactoring. I will look again at it and open an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In #2754 I've added the support for the experimental read-write deployment mode, excluding the Alertmanager. In this PR I'm adding the Alertmanager to the backend target.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]