Helm: fix distributor load balancing not working on scale up #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dimitarvdimitrov
approved these changes
Aug 30, 2022
Comment on lines
-24
to
-27
| server: | ||
| grpc_server_max_connection_age: | ||
| grpc_server_max_connection_age_grace: | ||
| grpc_server_max_connection_idle: |
The new defaults mean that gRPC will rebalance connections periodically, letting new servers have connections on scale-out. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
krajorama
force-pushed
the
krajo/20220830-grpc-lb
branch
from
94720ab
to
0955eb7
Compare
grafanabot
pushed a commit
that referenced
this pull request
Sep 7, 2022
) The new defaults mean that gRPC will rebalance connections periodically, letting new servers have connections on scale-out. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> (cherry picked from commit 957c33b)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
[from private repo]
Relates to: #2206
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]