Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated active_series_custom_trackers_config option in per-tenant limits #3110

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

pstibrany
Copy link
Member

What this PR does

This PR removes active_series_custom_trackers_config, which was deprecated in Mimir 2.2.0 (since #2101)

Checklist

  • Tests updated
  • [na] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…tenant limits.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany requested a review from a team as a code owner October 3, 2022 12:50
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
….3.0 already.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Contributor

@colega colega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Great, lgtm.

@pracucci
Copy link
Collaborator

pracucci commented Oct 3, 2022

Doh! I was working on it (plus other deprecated stuff to remove). I will keep your and rebase mine on top of this.

@pracucci pracucci mentioned this pull request Oct 3, 2022
45 tasks
@pstibrany
Copy link
Member Author

Doh! I was working on it (plus other deprecated stuff to remove). I will keep your and rebase mine on top of this.

Ah, sorry about that. I wasn't sure if you work on it or not. I should have checked with you instead.

@pracucci
Copy link
Collaborator

pracucci commented Oct 3, 2022

Doh! I was working on it (plus other deprecated stuff to remove). I will keep your and rebase mine on top of this.

Ah, sorry about that. I wasn't sure if you work on it or not. I should have checked with you instead.

Nah! I appreciated your proactive approach! 👏

@pracucci pracucci enabled auto-merge (squash) October 3, 2022 17:15
@pracucci pracucci merged commit ced3285 into main Oct 3, 2022
@pracucci pracucci deleted the remove-active_series_custom_trackers_config branch October 3, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants