Adding support for new config name #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
Jun 14, 2022
pstibrany
reviewed
Jun 15, 2022
There was a problem hiding this comment.
Thank you for this!
Since this change will be released in Mimir 2.2, we can only remove old field in Mimir 2.4. Let's keep only single TODO (next to ActiveSeriesCustomTrackersConfigOld field) for removal, and drop other TODOs. Compilation errors will show us what to change.
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
* Adding support for new config name * Hiding documentation of active_series_custom_trackers_config, but still supporting it at deserialization time * Clearing old config value, and adding a test case for this behaviour * Running make reference-help * Adding changelog describing change * Addressing Peter's comments * Tidying up testcases * Removing omitempty, as its behaviour is unexpected (not serializing the object at all) * Update CHANGELOG.md Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In #1188 the config name of
active_series_custom_trackershas been changed toactive_series_custom_trackers_configby accident. The aim of this PR is to change it back toąctive_series_custom_trackerswhile supporting the suffixed version for 2 releases.When both are specified, the old config takes precedence.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]