Revert "distributor: Wrap errors from pushing to ingesters" #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 82cd7b9.
Logiraptor
approved these changes
Oct 13, 2022
|
Reverting is great as an hot fix, but as a separate PR I would recommend adding tests that fail if the regression will be introduced again in the future. |
Agree completely with @pracucci, was also thinking that having tests catching this problem is important. |
|
I made an issue regarding re-introducing the error wrapping, together with regression tests. Hope to work on it in not too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3055
Resolves #3210