distributor: Wrap errors from pushing to ingesters #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
chore/distributor-wrap-push-error
branch
from
90958ac
to
c034f27
Compare
aknuds1
force-pushed
the
chore/distributor-wrap-push-error
branch
from
c034f27
to
578e9ae
Compare
replay
reviewed
Sep 27, 2022
aknuds1
force-pushed
the
chore/distributor-wrap-push-error
branch
from
578e9ae
to
42ec2e3
Compare
pstibrany
reviewed
Sep 28, 2022
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/distributor-wrap-push-error
branch
from
42ec2e3
to
bb2dff7
Compare
Logiraptor
pushed a commit
that referenced
this pull request
Oct 13, 2022
pstibrany
pushed a commit
that referenced
this pull request
Oct 14, 2022
grafanabot
pushed a commit
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In the distributor component, wrap errors stemming from calling the
pushgRPC method on ingesters. If an errors stems from a timeout, that gets wrapped with a specific message.I hope this will be useful in diagnosing write requests timing out in the ingester component (e.g. due to CPU starvation).
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]