-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packages] Fix incorrect OS value set in Mimir v2.3.* RPM package #3221
Conversation
Here is the resulting package build with this patch mimir.zip
|
When creating the packages on MacOS the `OS` applied on the package is not correct. The documentation says: --rpm-os OS The operating system to target this rpm for. You want to set this to ‘linux’ if you are using fpm on OS X, for example See: https://fpm.readthedocs.io/en/latest/packages/rpm.html Fixes: grafana#3216 Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
91dc0c2
to
9af0a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3221-to-release-2.4 origin/release-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 80e6fc10e7328fc38e156327be48b11d0c1f02e2
# Push it to GitHub
git push --set-upstream origin backport-3221-to-release-2.4
git switch main
# Remove the local backport branch
git branch -D backport-3221-to-release-2.4 Then, create a pull request where the |
) When creating the packages on MacOS the `OS` applied on the package is not correct. The documentation says: --rpm-os OS The operating system to target this rpm for. You want to set this to ‘linux’ if you are using fpm on OS X, for example See: https://fpm.readthedocs.io/en/latest/packages/rpm.html Fixes: #3216 Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> (cherry picked from commit 80e6fc1)
) (#3226) When creating the packages on MacOS the `OS` applied on the package is not correct. The documentation says: --rpm-os OS The operating system to target this rpm for. You want to set this to ‘linux’ if you are using fpm on OS X, for example See: https://fpm.readthedocs.io/en/latest/packages/rpm.html Fixes: #3216 Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> (cherry picked from commit 80e6fc1) Co-authored-by: wilfriedroset <wilfriedroset@users.noreply.github.com>
What this PR does
When creating the packages on MacOS the
OS
applied on the package is not correct. The documentation says:See: https://fpm.readthedocs.io/en/latest/packages/rpm.html
Which issue(s) this PR fixes or relates to
Fixes #3216
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]