Cherry pick #3221 #3226
Merged
Cherry pick #3221 #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) When creating the packages on MacOS the `OS` applied on the package is not correct. The documentation says: --rpm-os OS The operating system to target this rpm for. You want to set this to ‘linux’ if you are using fpm on OS X, for example See: https://fpm.readthedocs.io/en/latest/packages/rpm.html Fixes: #3216 Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> (cherry picked from commit 80e6fc1)
|
Is the changelog change correct? |
I think so. The "Grafana Mimir - main / unreleased" will be changed to rc.1 once I'm ready to cut the new version. |
aknuds1
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking #3221 into release-2.4