Don't reuse cached results when query is not step-aligned. #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
reviewed
Oct 27, 2021
pracucci
approved these changes
Oct 28, 2021
| "github.com/grafana/mimir/integration/e2emimir" | ||
| ) | ||
|
|
||
| func TestQueryFrontendUnalignedQuery(t *testing.T) { |
There was a problem hiding this comment.
Do you mind running the same test also with -query-frontend.max-sharded-queries-limit-enabled=true, please?
There was a problem hiding this comment.
Added test using new middleware too.
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Removed "Provenance-includes" statements. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
force-pushed
the
dont-reuse-cached-results-for-unaligned-queries
branch
from
e140dbb
to
f9f1ebc
Compare
|
Thanks for reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR fixes bug when cached results for step-aligned queries were reused when running query that is not step-aligned. Reusing cached result in such case ends in wrong result being returned by Mimir.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]