-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't reuse cached results when query is not step-aligned. #424
Don't reuse cached results when query is not step-aligned. #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
"github.com/grafana/mimir/integration/e2emimir" | ||
) | ||
|
||
func TestQueryFrontendUnalignedQuery(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind running the same test also with -query-frontend.max-sharded-queries-limit-enabled=true
, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added test using new middleware too.
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Removed "Provenance-includes" statements. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
e140dbb
to
f9f1ebc
Compare
Thanks for reviews! |
What this PR does: This PR fixes bug when cached results for step-aligned queries were reused when running query that is not step-aligned. Reusing cached result in such case ends in wrong result being returned by Mimir.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]