Use implicit histogram format within query-frontend #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
3 tasks
pracucci
approved these changes
Mar 1, 2023
| @@ -26,8 +26,12 @@ func TestGettingStartedWithGrafanaMimir(t *testing.T) { | |||
| defer s.Close() | |||
|
|
|||
| require.NoError(t, copyFileToSharedDir(s, "docs/configurations/demo.yaml", "demo.yaml")) | |||
| flags := map[string]string{ | |||
| // Enable protobuf format so that we can use native histograms. | |||
| "-query-frontend.query-result-response-format": "protobuf", | |||
There was a problem hiding this comment.
[non blocking] I can see you're enabling it in many tests. Given this is required to get native histograms work, what if we just enable it by default in integration/configs.go?
There was a problem hiding this comment.
In the future, having it as a default might make sense, but for now, I'd like to leave it out so I can be confident I haven't broken the existing JSON format. WDYT?
This unblocks query sharding for queries involving native histograms, and also unblocks using the new internal query result payload format between query-frontends and rulers.
… matrix values. This removes the need to convert them when decoding in the query-frontend. This does not change the wire format as the shapes of the messages (Sample/MatrixSample and FloatHistogramPair/MatrixHistogram) are the same.
This does not affect the wire format.
…native histograms.
charleskorn
force-pushed
the
charleskorn/use-implicit-histograms-inside-query-frontend
branch
from
1ddf845
to
c29269b
Compare
…ut-of-order` when trying to create test series.
charleskorn
deleted the
charleskorn/use-implicit-histograms-inside-query-frontend
branch
3 tasks
charleskorn
added a commit
that referenced
this pull request
Mar 3, 2023
This does not include the associated integration test changes, or changes to tests that have not yet been merged to main.
krajorama
pushed a commit
that referenced
this pull request
Mar 7, 2023
…istogram` onto `main` (#4360) * Cherry pick changes from #4269, #4303 and #4318 onto main. This does not include the associated integration test changes, or changes to tests that have not yet been merged to main. * Add support for JSON-encoding a single series with both float and histogram values. Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This unblocks query sharding for queries returning native histograms, and also unblocks using the new internal query result payload format between query-frontends and rulers.
With this change, queries that return native histograms will fail unless the protobuf internal query result payload format is enabled with
-query-frontend.query-result-response-format=protobuf.In addition to the main change above, there are two other small changes:
mimir.proto. Again, this does not change the wire format.I'd suggest reviewing each commit separately as the renames and type changes make the overall diff difficult to follow.
Which issue(s) this PR fixes or relates to
#4104
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]