-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve encoding and decoding performance for native histograms in new internal query result payload format #4303
Improve encoding and decoding performance for native histograms in new internal query result payload format #4303
Conversation
…obuf types and Prometheus' model types.
… in the same order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change makes sense to me. I let @krajorama review it too before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also we could reuse the requireSameShape function for other structs we have in there
This does not include the associated integration test changes, or changes to tests that have not yet been merged to main.
…istogram` onto `main` (#4360) * Cherry pick changes from #4269, #4303 and #4318 onto main. This does not include the associated integration test changes, or changes to tests that have not yet been merged to main. * Add support for JSON-encoding a single series with both float and histogram values. Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
What this PR does
This PR improves the performance of both encoding and decoding native histograms in the new internal query result payload format.
Benchmark results: encoding in querier
Benchmark results: decoding in query-frontend
Note that it requires a breaking change to the protobuf schema, but I believe this is acceptable given native histograms are an experimental feature and we're not yet running it in production.
Which issue(s) this PR fixes or relates to
#4104
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]