Make results cache TTL configurable and settable per tenant #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
approved these changes
Mar 6, 2023
|
This PR partially addresses #3832 too. |
1 task
pstibrany
force-pushed
the
make-results-cache-ttl-configurable
branch
from
5265fd1
to
21d8fec
Compare
pracucci
approved these changes
Mar 8, 2023
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
force-pushed
the
make-results-cache-ttl-configurable
branch
from
2018fb5
to
a2940a0
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR replaces hard-coded 7 days (and 10 minutes for queries within OOO window) TTL for results cache, and makes these values configurable per tenant. This allows us to use lower values for users who want to use backfill feature.
Which issue(s) this PR fixes or relates to
Fixes (partially) #4383
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]