Return time.Duration from limits, instead of model.Duration

[pstibrany]

What this PR does

This PR addresses comment #4385 (comment) from PR review. OutOfOrderTimeWindow was the only method in validation/limits.go returning model.Duration instead of time.Duration.

Checklist

• Tests updated
• [na] Documentation added
• [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

[pracucci]

I'm fine being consistent, but I suggest to add a CHANGELOG entry because after this change we're not going to accept anymore the extended duration units introduced by model.Duration (e.g. w, y, ...).

[56quarters]

I'm fine being consistent, but I suggest to add a CHANGELOG entry because after this change we're not going to accept anymore the extended duration units introduced by model.Duration (e.g. w, y, ...).

We will, the type in validation.Limits is still a model.Duration (and so we can still use the extended units in YAML). We just return time.Duration from the limits.OutOfOrderTimeWindow(userID) method which is called internally.

[pracucci]

I'm fine being consistent, but I suggest to add a CHANGELOG entry because after this change we're not going to accept anymore the extended duration units introduced by model.Duration (e.g. w, y, ...).

We will, the type in validation.Limits is still a model.Duration (and so we can still use the extended units in YAML). We just return time.Duration from the limits.OutOfOrderTimeWindow(userID) method which is called internally.

🤦 You're right. I looked at this too quickly.